Update dependencies, cleanup RSocketClient/Server implementation #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
approved these changes
Feb 1, 2018
robertroeser
reviewed
Feb 1, 2018
| @@ -64,16 +52,16 @@ public NettyDuplexConnection(NettyInbound in, NettyOutbound out, NettyContext co | |||
|
|
|||
| @Override | |||
| public void dispose() { | |||
| onClose.onComplete(); | |||
| context.dispose(); | |||
There was a problem hiding this comment.
This didn't seem to work reliably. Did this get fixed?
There was a problem hiding this comment.
I think the dispose part worked, the problem was the onClose callback not getting triggered when the process is forcibly killed, so this should be no worse than it is now. The real problem is that there are two sources of truth, the underlying channel and Netty's CloseFuture which seem to not always be in agreement. I'd like to add some tests to try to reproduce this, then see if there is a better way of making sure the CloseFuture always gets terminated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge some changes from JCTools, clean up a few places where synchronization is no longer needed after switching to NonBlockingHashMapLong