Release SetupFrame on RSocket version mismatch #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIUC: Offsets retain in NettyDuplexConnection and WebsocketDuplexConnection receive() |
|
@mostroverkhov do you think it is viable to verify the Buf reference counting in our existing tests? |
|
@yschimke SETUP_VERSION is hardcoded deeply in SetupFrameFlyweight - I can expose It in Frame.Setup.from() and add appropriate tests in follow-up PR. |
|
I was more wondering whether any of existing tests could check for memory leaks at the end of a run? I'm happy with your bug fix as is, if tests are still passing, I believe it means you haven't corrupted something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #471