Shadow JCTools #476
Merged
Shadow JCTools #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a number of classes from JCTools had been copied and pasted into the code in order to avoid a JAR-level dependencies on the project. While the goal was worthy, the implementation led itself to divergence as the classes in JCTools were improved and bugs were fixed. Even the JCTools project discourages this behavior, instead recommending that you shadow/shade in the dependency. From the RSocket perspective, this has the advantage of allowing the dependency to be specified and kept up to date in the same way that all the other dependencies of the projects are, and yet still not resulting in a JAR-level dependency on JCTools. This change updates the code to use JCTools directly as a dependency and introduces the shadow plugin, configured to include just the types needed by the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a number of classes from JCTools had been copied and pasted into the code in order to avoid a JAR-level dependencies on the project. While the goal was worthy, the implementation led itself to divergence as the classes in JCTools were improved and bugs were fixed. Even the JCTools project discourages this behavior, instead recommending that you shadow/shade in the dependency. From the RSocket perspective, this has the advantage of allowing the dependency to be specified and kept up to date in the same way that all the other dependencies of the projects are, and yet still not resulting in a JAR-level dependency on JCTools.
This change updates the code to use JCTools directly as a dependency and introduces the shadow plugin, configured to include just the types needed by the code.