Skip to content

Remove nested flatMap in RSocketFactory #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2018
Merged

Remove nested flatMap in RSocketFactory #493

merged 2 commits into from
May 7, 2018

Conversation

rdegnan
Copy link
Member

@rdegnan rdegnan commented May 7, 2018

No description provided.

@rdegnan rdegnan requested a review from robertroeser May 7, 2018 18:56
nebhale
nebhale approved these changes May 7, 2018
View reviewed changes
Copy link
Member

@nebhale nebhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that "introduce an unnecessary Mono" pattern!

@rdegnan rdegnan merged commit ce207ba into rsocket:1.0.x May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebhale nebhale nebhale approved these changes

@robertroeser robertroeser Awaiting requested review from robertroeser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdegnan @nebhale