Skip to content

Slow Test Run Configuration #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Slow Test Run Configuration #512

merged 1 commit into from
Jul 10, 2018

Conversation

nebhale
Copy link
Member

@nebhale nebhale commented Jul 9, 2018

Currently the TransportTest#requestChannel2_000_000 test (for all transports) takes a very long time on some systems. It's a useful test to have, but not necessarily to run at all times. This change creates an @SlowTest annotation that is meta-annotated so that tests will only be enabled if TEST_SLOW_ENABLED=true has been set.

[resolves #511 ]

Currently the TransportTest#requestChannel2_000_000 test (for all transports)
takes a very long time on some systems.  It's a useful test to have, but not
necessarily to run at all times.  This change creates an @slowtest annotation
that is meta-annotated so that tests will only be enabled if
TEST_SLOW_ENABLED=true has been set.

[resolves #511]
@yschimke
Copy link
Member

@nebhale do you have write permissions?

@yschimke yschimke merged commit 60b8201 into rsocket:1.0.x Jul 10, 2018
@nebhale
Copy link
Member Author

nebhale commented Jul 10, 2018

@yschimke I do not. Just PRs so far.

@nebhale nebhale deleted the 503-slow-test-config branch February 20, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants