Skip to content

Update reactor bom version to Californium-SR3 #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

aharonha
Copy link
Contributor

@aharonha aharonha commented Dec 5, 2018

No description provided.

@aharonha
Copy link
Contributor Author

aharonha commented Dec 5, 2018

Please release a version with this change

@OlegDokuka OlegDokuka self-requested a review December 5, 2018 13:02
Copy link
Member

@OlegDokuka OlegDokuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! LGTM. Anyway, you can override these dependencies locally while PR is under review.

@yschimke
Copy link
Member

yschimke commented Dec 5, 2018

Some google fun from the future, 11 hours from now

image

@aharonha
Copy link
Contributor Author

aharonha commented Dec 5, 2018

@OlegDokuka do you mean that I should set the next version in this PR?

@OlegDokuka
Copy link
Member

@aharonha I mean that you could exclude netty and Rector-xx dependencies from the original RSocket-Core on to the required ones while this PR is unmerged.

@OlegDokuka OlegDokuka merged commit 29e5c01 into rsocket:1.0.x Dec 5, 2018
@aharonha aharonha deleted the patch-1 branch December 6, 2018 06:28
@aharonha aharonha restored the patch-1 branch December 6, 2018 06:30
@aharonha
Copy link
Contributor Author

aharonha commented Dec 6, 2018

The build was failed. I believe that's my fault so I should open a new PR for upgrading the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants