Adds specific requestChannel(Payload, Publisher<Payload>) #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uestChannel Signed-off-by: Robert Roeser <[email protected]>
robertroeser
force-pushed
the
requestChannelImprovements
branch
from
43d44ee to
48acae8
Compare
yschimke
reviewed
Jan 28, 2019
| import reactor.core.publisher.Flux; | ||
|
|
||
| /** | ||
| * Extends the {@link RSocket} that allows an implementor to peek at the first request payload of a channel. |
There was a problem hiding this comment.
Suggested change
| * Extends the {@link RSocket} that allows an implementor to peek at the first request payload of a channel. | |
| * Extends the {@link RSocket} that allows an implementer to peek at the first request payload of a channel. |
yschimke
reviewed
Jan 28, 2019
| */ | ||
| public interface RequestHandler extends RSocket { | ||
| /** | ||
| * Implement this method to peak at the first payload of the incoming request stream |
There was a problem hiding this comment.
Maybe clarify that peak means that payloads still includes the peaked payload.
Signed-off-by: Robert Roeser <[email protected]>
smaldini
reviewed
Jan 29, 2019
|
|
||
| private final DuplexConnection connection; | ||
| private final RSocket requestHandler; | ||
| private final RequestHandler optimizedRequestHandler; | ||
| private final boolean hasOptimizedRequestHandler; |
There was a problem hiding this comment.
No need for an extra boolean property, just checking optimizedRequestHandler != null should be fine
smaldini
reviewed
Jan 29, 2019
| if (requestHandler instanceof RequestHandler) { | ||
| this.optimizedRequestHandler = (RequestHandler) requestHandler; | ||
| this.hasOptimizedRequestHandler = true; | ||
| this.requestHandler = null; |
There was a problem hiding this comment.
I would keep the requestHandler assigned anyway for consistency.
Signed-off-by: Robert Roeser <[email protected]>
robertroeser
force-pushed
the
requestChannelImprovements
branch
from
4d69ee2 to
92a4d1d
Compare
yschimke
reviewed
Jan 30, 2019
Signed-off-by: Robert Roeser <[email protected]>
robertroeser
force-pushed
the
requestChannelImprovements
branch
from
6eaef08 to
f2a73a8
Compare
nebhale
approved these changes
Jan 31, 2019
robertroeser
added a commit
that referenced
this pull request
Feb 8, 2019
* optimize request channel to let you peak at the first item in the requestChannel Signed-off-by: Robert Roeser <[email protected]> * updated javadoc Signed-off-by: Robert Roeser <[email protected]> * updates Signed-off-by: Robert Roeser <[email protected]> * call requestChannelWith 2 arguments Signed-off-by: Robert Roeser <[email protected]> Signed-off-by: Robert Roeser <[email protected]>
robertroeser
added a commit
that referenced
this pull request
Feb 12, 2019
* Adds specific requestChannel(Payload, Publisher<Payload>) (#572) * optimize request channel to let you peak at the first item in the requestChannel Signed-off-by: Robert Roeser <[email protected]> * updated javadoc Signed-off-by: Robert Roeser <[email protected]> * updates Signed-off-by: Robert Roeser <[email protected]> * call requestChannelWith 2 arguments Signed-off-by: Robert Roeser <[email protected]> Signed-off-by: Robert Roeser <[email protected]> * first pass at refactoring to idomatic ByteBuf flyweights Signed-off-by: Robert Roeser <[email protected]> * fixing tests Signed-off-by: Robert Roeser <[email protected]> * fixed some more tests Signed-off-by: Robert Roeser <[email protected]> * fix frame flyweights Signed-off-by: Robert Roeser <[email protected]> * testing Signed-off-by: Robert Roeser <[email protected]> * accept ByteBufAllocator in a constructors and renames FrameDecoder to PayloadDecoder Signed-off-by: Robert Roeser <[email protected]> * javadoc Signed-off-by: Robert Roeser <[email protected]> * first pass at refactoring to idomatic ByteBuf flyweights Signed-off-by: Robert Roeser <[email protected]> * fixing tests Signed-off-by: Robert Roeser <[email protected]> * fixed some more tests Signed-off-by: Robert Roeser <[email protected]> * testing Signed-off-by: Robert Roeser <[email protected]> * fix frame flyweights Signed-off-by: Robert Roeser <[email protected]> * accept ByteBufAllocator in a constructors and renames FrameDecoder to PayloadDecoder Signed-off-by: Robert Roeser <[email protected]> * javadoc Signed-off-by: Robert Roeser <[email protected]> * setup frame flyweight: allow null metadata restore micrometer RSocket test Signed-off-by: Maksym Ostroverkhov <[email protected]> * apply fixes from review release ByteBufs in tests Signed-off-by: Maksym Ostroverkhov <[email protected]>
|
Not sure if this is expected or not but I tried using the Perhaps there needs to be an |
mostroverkhov
pushed a commit
to mostroverkhov/rsocket-java
that referenced
this pull request
Feb 27, 2019
* Adds specific requestChannel(Payload, Publisher<Payload>) (rsocket#572) * optimize request channel to let you peak at the first item in the requestChannel Signed-off-by: Robert Roeser <[email protected]> * updated javadoc Signed-off-by: Robert Roeser <[email protected]> * updates Signed-off-by: Robert Roeser <[email protected]> * call requestChannelWith 2 arguments Signed-off-by: Robert Roeser <[email protected]> Signed-off-by: Robert Roeser <[email protected]> * first pass at refactoring to idomatic ByteBuf flyweights Signed-off-by: Robert Roeser <[email protected]> * fixing tests Signed-off-by: Robert Roeser <[email protected]> * fixed some more tests Signed-off-by: Robert Roeser <[email protected]> * fix frame flyweights Signed-off-by: Robert Roeser <[email protected]> * testing Signed-off-by: Robert Roeser <[email protected]> * accept ByteBufAllocator in a constructors and renames FrameDecoder to PayloadDecoder Signed-off-by: Robert Roeser <[email protected]> * javadoc Signed-off-by: Robert Roeser <[email protected]> * first pass at refactoring to idomatic ByteBuf flyweights Signed-off-by: Robert Roeser <[email protected]> * fixing tests Signed-off-by: Robert Roeser <[email protected]> * fixed some more tests Signed-off-by: Robert Roeser <[email protected]> * testing Signed-off-by: Robert Roeser <[email protected]> * fix frame flyweights Signed-off-by: Robert Roeser <[email protected]> * accept ByteBufAllocator in a constructors and renames FrameDecoder to PayloadDecoder Signed-off-by: Robert Roeser <[email protected]> * javadoc Signed-off-by: Robert Roeser <[email protected]> * setup frame flyweight: allow null metadata restore micrometer RSocket test Signed-off-by: Maksym Ostroverkhov <[email protected]> * apply fixes from review release ByteBufs in tests Signed-off-by: Maksym Ostroverkhov <[email protected]> Signed-off-by: Maksym Ostroverkhov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize request channel to let you peak at the first item in the stream #569