fixes issue with fragmentation when the MTU size is set to 64 bytes #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Roeser <[email protected]>
robertroeser
force-pushed
the
bugfix/fragmentationRefCntBug
branch
from
6ec4540 to
f4895c1
Compare
mostroverkhov
approved these changes
Apr 12, 2019
SerCeMan
reviewed
Nov 29, 2019
| @@ -11,7 +11,7 @@ | |||
| class DefaultPayloadDecoder implements PayloadDecoder { | |||
|
|
|||
| @Override | |||
| public Payload apply(ByteBuf byteBuf) { | |||
| public synchronized Payload apply(ByteBuf byteBuf) { | |||
There was a problem hiding this comment.
Hi, @robertroeser! I've run a benchmark with multiple clients sending messages concurrently, and lock profiler (a part of async-profiler) showed that there was lock contention in DefaultPayloadDecoder which seems to be introduced in this PR.
I've looked through the code, but it's not obvious to me why it requires synchronisation since the class seems to be stateless. So, I'm wondering whether this synchronized can be safely removed in which case I'll be happy to send a PR or it serves some reason.
Thanks :)
There was a problem hiding this comment.
Hello, @SerCeMan!
Thanks for finding that. I guess that was done by mistake and there is no need to have synchronized keyword here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #615