added logic to handle different websocket frames #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Roeser <[email protected]>
robertroeser
force-pushed
the
bugfix/handlePingFrame
branch
from
d60b263 to
ec8085d
Compare
Signed-off-by: Robert Roeser <[email protected]>
Signed-off-by: Robert Roeser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the WebSocket transport receives a frame a Ping,Pong or Close frame it doesn't handle it properly. It passes it on to RSocket which creates an exception. I added logic to handle the ping and pong frames. I also added logic to handle a close frame.