RSocketRequester: fix concurrent modification of senders & receivers … #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostroverkhov
force-pushed
the
feature/termination-errors-fix
branch
from
48e3da4 to
2dcfe1c
Compare
…map on termination fix non-deterministic errors order on termination Signed-off-by: Maksym Ostroverkhov <[email protected]>
yschimke
reviewed
Oct 15, 2019
yschimke
reviewed
Oct 15, 2019
mostroverkhov
force-pushed
the
feature/termination-errors-fix
branch
from
258606b to
fe6b59e
Compare
Signed-off-by: Maksym Ostroverkhov <[email protected]>
|
Drive by review - I'll leave more thorough reviews to others. Looks sensible enough. |
Signed-off-by: Maksym Ostroverkhov <[email protected]>
OlegDokuka
pushed a commit
that referenced
this pull request
Mar 2, 2020
#706) * RSocketRequester: fix concurrent modification of senders & receivers map on termination fix non-deterministic errors order on termination Signed-off-by: Maksym Ostroverkhov <[email protected]> * improve test Signed-off-by: Maksym Ostroverkhov <[email protected]> * address review Signed-off-by: Maksym Ostroverkhov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSocketRequester: fix concurrent modification of senders & receivers map on termination, closes #679, #695
fix non-deterministic errors order on termination, closes #686