Remove rsocket-examples from generated BOM. #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rsocket#714 Signed-off-by: Franz Becker <[email protected]>
franzbecker
force-pushed
the
feature/issue-714_remove-rsocket-examples-from-bom
branch
from
34d1fcf to
b30dacc
Compare
franzbecker
commented
Nov 11, 2019
| @@ -24,7 +24,7 @@ description = 'RSocket Java Bill of materials.' | |||
|
|
|||
| dependencies { | |||
| constraints { | |||
| parent.subprojects.findAll { it.name != project.name }.sort { "$it.name" }.each { | |||
| parent.subprojects.findAll { it.name != project.name && it.name != "rsocket-examples" }.sort { "$it.name" }.each { | |||
There was a problem hiding this comment.
Alternatively you could create a more generic logic that goes something like this:
parent.subprojects.findAll { it.name != project.name }.sort { "$it.name" }.each { subproject ->
subproject.plugins.withType(MavenPublishPlugin.class) {
api subproject
}
}
|
Looks good. Thanks for contribution |
|
@OlegDokuka would you mind releasing that change as another RC or could you tell me when you plan to release the next one? Thanks! |
franzbecker
deleted the
feature/issue-714_remove-rsocket-examples-from-bom
branch
OlegDokuka
pushed a commit
that referenced
this pull request
Mar 2, 2020
Fixes #714 Signed-off-by: Franz Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #714