fixes error handling to match specification #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
force-pushed
the
bugfix/extended-error-handling
branch
from
8f5f49b to
e11f307
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
bugfix/extended-error-handling
branch
from
e11f307 to
0322be9
Compare
gregwhitaker
approved these changes
Dec 7, 2019
yschimke
reviewed
Dec 7, 2019
yschimke
reviewed
Dec 7, 2019
yschimke
reviewed
Dec 8, 2019
| return new InvalidException(message); | ||
| default: | ||
| if (errorCode >= MIN_USER_ALLOWED_ERROR_CODE | ||
| || errorCode <= MAX_USER_ALLOWED_ERROR_CODE) { |
There was a problem hiding this comment.
On re-reading on a computer (not Github iOS tesatflight app :), this seems good.
if (errorCode >= 769
|| errorCode <= -2) {
yschimke
reviewed
Dec 8, 2019
Comment on lines
+20
to
+21
| if (errorCode > ErrorType.MAX_USER_ALLOWED_ERROR_CODE | ||
| && errorCode < ErrorType.MIN_USER_ALLOWED_ERROR_CODE) { |
There was a problem hiding this comment.
Looks legit, sorry.
if (errorCode > -2
&& errorCode < 769) {
|
So, yeah, to clarify, since error API expect int and return int, we cannot use long for that purpose, that is why had to deal with such unobvious comparison |
OlegDokuka
added a commit
that referenced
this pull request
Mar 2, 2020
Signed-off-by: Oleh Dokuka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the current implementation of error handling to match what is defined in the spec and let the user use a range of user allowed error codes using
CastomRSocketExceptionclassSigned-off-by: Oleh Dokuka [email protected]