Send root-cause errors from connection to onClose of RSocket #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Dokuka <[email protected]>
rstoyanchev
reviewed
Apr 26, 2020
| @@ -619,6 +623,10 @@ private void tryTerminateOnKeepAlive(KeepAlive keepAlive) { | |||
| String.format("No keep-alive acks for %d ms", keepAlive.getTimeout().toMillis()))); | |||
| } | |||
|
|
|||
| private void tryTerminateOnConnectionClose(Throwable e) { | |||
| tryTerminate(() -> e); | |||
| } | |||
There was a problem hiding this comment.
tryTerminateOnConnectionError perhaps?
| } | ||
| private void tryTerminateOnConnectionClose(Throwable e) { | ||
| tryTerminate(() -> e); | ||
| } |
There was a problem hiding this comment.
tryTerminateOnConnectionError?
Co-Authored-By: Rossen Stoyanchev <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
rstoyanchev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to previous
RSocketFactory#errorConsumerdeprecation and future removal.That said, we have to have access to the reason of RSocket termination and right now it would be the best to enhance
Mono<Void> onCloseand propagate the root-cause error (e.g Stream ID 0 errors which are terminal) over that APISigned-off-by: Oleh Dokuka [email protected]