Deprecate AbstractRSocket and provide alternative #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change deprecates AbstractRSocket in favor of implementing RSocket directly. In turn RSocket has default methods for the basic interactions while onClose now returns Mono.never() by default and has to be implemented anyway if it is to something more meaningful. In addition SocketAcceptor provides static factor methods that provide shortcuts for handling one type of interaction with a lambda syntax. Signed-off-by: Rossen Stoyanchev <[email protected]>
rstoyanchev
force-pushed
the
abstract-rsocket
branch
from
968de46 to
7cfdc5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deprecates
AbstractRSocketin favor of implementingRSocketdirectly. In turn RSocket has default methods for the basic interactions whileonClose()now returnsMono.never()by default and has to be implemented anyway if it is to do something more meaningful.In addition
SocketAcceptorprovides static factory methods as shortcuts for handling one type of interaction with a lambda syntax.