provides well documented lease example #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
force-pushed
the
docs/lease-example
branch
from
4b71165 to
2680d32
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
docs/lease-example
branch
from
2680d32 to
c87365b
Compare
rstoyanchev
requested changes
May 18, 2020
There was a problem hiding this comment.
Nice example. I've added a few suggestions below.
Do we still need the LeaseExample? It's not connected to the lease notifications from the remote it seems, and retries blindly every second. In any case it doesn't seem to demonstrate anything extra so perhaps this can just replace it.
| try { | ||
| while (!Thread.currentThread().isInterrupted()) { | ||
| String message = messagesQueue.poll(Long.MAX_VALUE, TimeUnit.DAYS); | ||
| System.out.println("Process message {" + message + "}"); |
There was a problem hiding this comment.
Replace all System.out with a Logger.
...ples/src/main/java/io/rsocket/examples/transport/tcp/lease/RateLimitingWithLeaseExample.java
Outdated
Show resolved
Hide resolved
...ples/src/main/java/io/rsocket/examples/transport/tcp/lease/RateLimitingWithLeaseExample.java
Outdated
Show resolved
Hide resolved
| String.format("%s stats are %s", tag, leaseStats.isPresent() ? "present" : "absent")); | ||
| Duration ttlDuration = Duration.ofSeconds(5); | ||
| // The interval function is used only for the demo purpose and should not be | ||
| // considered as the way to issue leases. |
There was a problem hiding this comment.
It would be helpful to describe what would be used instead of interval?
There was a problem hiding this comment.
…cp/lease/RateLimitingWithLeaseExample.java Co-authored-by: Rossen Stoyanchev <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]>
Co-authored-by: Rossen Stoyanchev <[email protected]> Signed-off-by: Oleh Dokuka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a good example which shows how Lease can be used for the straight-forward rate-limiting of FireAndForget calls
Signed-off-by: Oleh Dokuka [email protected]