ensures lease is used exactly on request frame sending #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
task/moves-lease-to-request-level
branch
from
ce9a3e2 to
118f5bf
Compare
rstoyanchev
requested changes
Jun 3, 2020
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that lease is used right before when the actual request frame is being sent.
That said that right now lease is used even though the
Publishergiven as the result of therequestXXXmethod execution is not subscribed (which of course may break lease counting on the client- vs server-side)Signed-off-by: Oleh Dokuka [email protected]