error message transformer #86
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| PrintWriter printWriter = new PrintWriter(writer); | ||
| throwable.printStackTrace(printWriter); | ||
| String data = writer.toString(); | ||
| byte[] bytes = data.getBytes(Charset.forName("UTF-8")); |
There was a problem hiding this comment.
nit: You can use StandardCharsets.UTF_8 instead of charset lookup.
|
I am not a big fan of sending stacktraces back to the caller over the network but if you think it is useful 👍 |
| StringWriter writer = new StringWriter(); | ||
| PrintWriter printWriter = new PrintWriter(writer); | ||
| throwable.printStackTrace(printWriter); | ||
| String data = writer.toString(); |
There was a problem hiding this comment.
I would prepend throwable.getMessage() == null ? "" : throwable.getMessage(); to the data String (sperated by new line) so that in both cases the data starts by the same thing.
|
👍 |
|
Closing this in preparation for the latest code push (ref #175) |
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
Clean up lots of typos and grammar in FAQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a transformer in the Frame.Error class to suck in the whole stack trace and send that as an error message payload optionally.