Frame instance was referenced longer than required. #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: `handleXXX` methods in `Responder` were closing over the passed `requestFrame` and using it later in the lifecycle of request processing. `Frame` objects and the underlying buffers are not designed to be retained after the scope of the parent method as these objects are threadlocal and reused. This causes issues when the frame object is referenced later in the request processing (eg: `cleanup()`) Solution: The only reason frame object was retained was to get the stream Id. This change pre-fetches the `streamId` and uses that from within the processing closure. Result: No more issue with frame access.
|
👍 This looks good, thanks for the fix! |
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
US Typo and reword the frame length requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
handleXXXmethods inResponderwere closing over the passedrequestFrameand using it later in the lifecycle of request processing.Frameobjects and the underlying buffers are not designed to be retained after the scope of the parent method as these objects are threadlocal and reused. This causes issues when the frame object is referenced later in the request processing (eg:cleanup())Solution:
The only reason frame object was retained was to get the stream Id. This change pre-fetches the
streamIdand uses that from within the processing closure.Result:
No more issue with frame access.