Skip to content

Reject any frames before SETUP/LEASE #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

rstoyanchev
Copy link
Contributor

Proposed fix for #884.

@rstoyanchev rstoyanchev added this to the 1.0.2 milestone Aug 3, 2020
@rstoyanchev rstoyanchev requested a review from OlegDokuka August 3, 2020 10:45
@rstoyanchev rstoyanchev self-assigned this Aug 3, 2020
Copy link
Member

@OlegDokuka OlegDokuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Closes rsocketgh-884

Signed-off-by: Rossen Stoyanchev <[email protected]>
@rstoyanchev rstoyanchev force-pushed the 884-overflow-before-setup branch from a9dcc51 to d1e0507 Compare August 3, 2020 12:04
@rstoyanchev rstoyanchev merged commit d1e0507 into rsocket:1.0.x Aug 3, 2020
@rstoyanchev rstoyanchev deleted the 884-overflow-before-setup branch August 3, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server memory overflow due to unbounded caching of all incoming frames until SETUP/RESUME are received.
2 participants