Setup the initial build for rspec-autotest #1
Conversation
|
(ping @myronmarston @alindeman @samphippen etc) |
|
I'll try to review this tonight... |
|
❤️ Sorry to hassle you, just making sure it got found.:) |
| # Derived from the `Autotest` class, extends the `autotest` command to work | ||
| # with RSpec. | ||
| # | ||
| class Autotest::Rspec2 < Autotest |
There was a problem hiding this comment.
Should this be RSpec or Rspec? (I suppose it should be whatever it was before....)
There was a problem hiding this comment.
This was Autotest::Rspec2 before
autotest will automatically require autotest/rspec2 but having this in rspec-autotest this will conflict with rspec-core so both autotest/rspec2 files will automatically require rspec/autotest
|
@myronmarston I've checked this with running the following tests:
|
|
👍 Works for me. |
|
|
||
| spec.required_ruby_version = '>= 1.8.7' | ||
|
|
||
| spec.add_dependency "rspec-core", ">= 2.9.9" |
There was a problem hiding this comment.
This should be 2.99 not, 2.9.9. They mean different things.
| #{'*'*50} | ||
| EOS | ||
| exit(1) | ||
| end |
There was a problem hiding this comment.
Why does this file need to be here? It adds duplication with rspec-core, and will add complication when we remove rspec/autorun...
There was a problem hiding this comment.
Because I couldn't think of a way to correctly determine the absolute path to rspec-core's executable and we are referencing it at
rspec-autotest/lib/rspec/autotest.rb
Line 13 in 96411a0
rspec-autotest/lib/rspec/autotest.rb
Line 53 in 96411a0
There was a problem hiding this comment.
What if rspec-core exposed it via a public API?
Something like RSpec::Core.path_to_executable ?
There was a problem hiding this comment.
Done, I don't have admin access to the repo but can we get TravisCI setup on this? (I can't flick the switch as a contributor) and we also need to set master as the main branch (Github thinks this branch is mainline atm it seems)
|
BTW, I went ahead and pushed a version of this to rubygems.org just to ensure we get the name rspec-autotest (I can imagine someone squatting on it after seeing this new repo appear). |
Setup the initial build for rspec-autotest
As a PR