Skip to content

Adds autotest code extracted from rspec-rails #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2013
Merged

Conversation

alindeman
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling ea7926d on rspec-rails into e6748c8 on master.

alindeman added a commit to rspec/rspec-rails that referenced this pull request Aug 9, 2013
@JonRowe
Copy link
Member

JonRowe commented Aug 10, 2013

The path I went through to check this worked a-ok with plain rspec was to run a dummy project on 2-14, then 2-99 with deprecation warning, then pulling in this to remove warning, then running plain 3. This was useful because it caught a few hangups (like require orders of files, constant usage and the rspec command) which I missed (and the specs missed). Have you done something similar? Otherwise LGTM

@alindeman
Copy link
Contributor Author

Good call. I thought I had done all those things, but just ran through them again in the context of a Rails project. It works as we'd expect (2-99 gets a deprecation, master doesn't work at all, master works again with this gem)

alindeman added a commit that referenced this pull request Aug 10, 2013
Adds autotest code extracted from rspec-rails
@alindeman alindeman merged commit 318f09e into master Aug 10, 2013
@alindeman alindeman deleted the rspec-rails branch August 10, 2013 14:37
@alindeman
Copy link
Contributor Author

@myronmarston, we might want to push another release/prerelease to gemcutter?

@myronmarston
Copy link
Member

@myronmarston, we might want to push another release/prerelease to gemcutter?

I just added you and @JonRowe as owners. I'll leave you two to it :).

@alindeman
Copy link
Contributor Author

Great. Decided to hold off a bit until RSpec 3 is imminent after discussing it with @samphippen. Anyone who needs this gem will also be running the git version of rspec-*.

@JonRowe
Copy link
Member

JonRowe commented Aug 12, 2013

FYI, this will be needed when 2-99 drop's to remove the warning, I'm curious why @samphippen is against dropping a pre release? (Git repo's in my mind make testing combinations of gem's slightly harder...)

@alindeman
Copy link
Contributor Author

I could go either way. @samphippen want to weigh in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants