Extract Rails extension to have matcher #5
Conversation
|
Looks like this is failing on Travis - it was passing for me locally so I'm not immediately certain what is amiss. HMM. |
| @@ -0,0 +1,8 @@ | |||
| module RSpec | |||
| module CollectionMatchers | |||
| module Rails | |||
There was a problem hiding this comment.
Do we need to define an empty module?
|
@soulcutter Maybe it's failing because the |
|
It shouldn't have to do with the |
|
@soulcutter Although you've now linked this to master, it needs to work with |
| @@ -7,12 +7,15 @@ gemspec | |||
| if File.exist?(library_path) | |||
| gem lib, :path => library_path | |||
| else | |||
| gem lib, :git => "git://github.com/rspec/#{lib}.git", :branch => "2-99-maintenance" | |||
| gem lib, :git => "git://github.com/rspec/#{lib}.git", :branch => "master" | |||
There was a problem hiding this comment.
We need to ensure this works against 2-99-maintenance and master
|
Bump..this needs to still be worked out. |
|
@soulcutter are you going to continue working on this? I can work on that if you're not going to. |
|
I think I solved the 2.99 compatibility issue, let's see what Travis says… EDIT: Nope… looks like something is different in 1.8.x rubies. |
instance_methods returns an array of symbols in Ruby 1.9+ but before that it was an array of strings.
|
Looks like the build works now. Any other feedback? |
| end | ||
| end | ||
| end | ||
|
|
|
@hugobarauna I'm all done with this one - care to comment / merge? |
| @@ -0,0 +1,58 @@ | |||
| require 'rspec/collection_matchers/have' | |||
There was a problem hiding this comment.
I'm not sure if we need that require here, since we're already loading that file in lib/rspec/collection_matchers/rails
There was a problem hiding this comment.
I'm not sure rails.rb really deserves to exist, honestly. It's not actually loaded there, though, it's really coming from lib/rspec/collection_matchers.rb
|
|
Extract Rails extension to have matcher
This functionality was extracted into rspec/rspec-collection_matchers#5 Fixes rspec#808
I'm not sure this is the best way to conditionally load the matcher extension, but I figured it's at least a workable first pass.
This is half of rspec/rspec-rails#808