This repository was archived by the owner on Nov 30, 2024. It is now read-only.
File tree Expand file tree Collapse file tree 2 files changed +6
-10
lines changed Expand file tree Collapse file tree 2 files changed +6
-10
lines changed Original file line number Diff line number Diff line change @@ -92,10 +92,8 @@ def initialize(runner, channel)
92
92
93
93
def dispatch_specs ( run_descriptor )
94
94
fork { run_specs ( run_descriptor ) }
95
- # We don't wait anymore that the subprocess is done with a waitpid
96
- # because there is no need to. On OSX and Linux, with more than
97
- # 1548 tests we were filling-up the pipe and saturating it. This
98
- # ended up with stuck bisect command.
95
+ # We don't use Process.waitpid here as it was causing bisects to
96
+ # block due to the file descriptor limit on OSX / Linux.
99
97
end
100
98
101
99
private
Original file line number Diff line number Diff line change @@ -33,12 +33,10 @@ def bisect(cli_args, expected_status=nil)
33
33
end
34
34
end
35
35
36
- context "when the bisect command is long" do
37
- # On OSX and Linux when we have many tests we could had pipe size issue. We did not empty the buffer
38
- # and we ended up with a pipe that was full and it was blocking the main process. This made the bisect
39
- # command stuck without further information. This test run blocking_pipe_bisect_spec.rb_ that
40
- # will ensure that we are not blocked anymore in this kind of situation.
41
- # https://github.com/rspec/rspec-core/pull/2669
36
+ context "when the bisect commasaturingnd is long" do
37
+ # On OSX and Linux a file descriptor limit meant that the bisect process got stuck at a certain limit.
38
+ # This test demonstrates that we can run large bisects above this limit (found to be at time of commit).
39
+ # See: https://github.com/rspec/rspec-core/pull/2669
42
40
it 'does not hit pipe size limit and does not get stuck' do
43
41
output = bisect ( %W[ spec/rspec/core/resources/blocking_pipe_bisect_spec.rb_ ] , 1 )
44
42
expect ( output ) . to include ( "No failures found." )
You can’t perform that action at this time.
0 commit comments