Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Commit 7c79e17

Browse files
committed
Document why we do not need to wait for child process to exit (waitpid)
1 parent b9ce89f commit 7c79e17

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lib/rspec/core/bisect/fork_runner.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,10 @@ def initialize(runner, channel)
9292

9393
def dispatch_specs(run_descriptor)
9494
fork { run_specs(run_descriptor) }
95+
# We don't wait anymore that the subprocess is done with a waitpid
96+
# because there is no need to. On OSX and Linux, with more than
97+
# 1548 tests we were filling-up the pipe and saturating it. This
98+
# ended up with stuck bisect command.
9599
end
96100

97101
private

0 commit comments

Comments
 (0)