Merge pull request #1493 from postmodern/code_smell

Code smell

Author: JonRowe

lib/rspec/core/rake_task.rb

@@ -60,16 +60,15 @@ class RakeTask < ::Rake::TaskLib
       attr_accessor :rspec_opts
 
       def initialize(*args, &task_block)
-        setup_ivars(args)
-
-        desc "Run RSpec code examples" unless ::Rake.application.last_comment
+        @name          = args.shift || :spec
+        @ruby_opts     = nil
+        @rspec_opts    = nil
+        @verbose       = true
+        @fail_on_error = true
+        @rspec_path    = 'rspec'
+        @pattern       = './spec{,/*/**}/*_spec.rb'
 
-        task name, *args do |_, task_args|
-          RakeFileUtils.__send__(:verbose, verbose) do
-            task_block.call(*[self, task_args].slice(0, task_block.arity)) if task_block
-            run_task verbose
-          end
-        end
+        define(args, &task_block)
       end
 
       # @private
@@ -91,14 +90,15 @@ def run_task(verbose)
     private
 
       # @private
-      def setup_ivars(args)
-        @name          = args.shift || :spec
-        @ruby_opts     = nil
-        @rspec_opts    = nil
-        @verbose       = true
-        @fail_on_error = true
-        @rspec_path    = 'rspec'
-        @pattern       = './spec{,/*/**}/*_spec.rb'
+      def define(args, &task_block)
+        desc "Run RSpec code examples" unless ::Rake.application.last_comment
+
+        task name, *args do |_, task_args|
+          RakeFileUtils.__send__(:verbose, verbose) do
+            task_block.call(*[self, task_args].slice(0, task_block.arity)) if task_block
+            run_task verbose
+          end
+        end
       end
 
       def files_to_run