Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Code smell #1493

Merged
merged 2 commits into from
Apr 18, 2014
Merged

Code smell #1493

merged 2 commits into from
Apr 18, 2014

Conversation

postmodern
Copy link
Contributor

  • Minor modifications to RSpec::Core::RakeTasks private API.
    • Moved rake task definition into #define.
    • Merged #setup_ivars back into #initialize.

@cupakromer
Copy link
Member

LGTM

I was going to comment on define being a generic name and possibly having naming conflicts. However, I see in the Rake code this is already an idiom which is standardized on. Perhaps amend the commit message to add that in?

@postmodern
Copy link
Contributor Author

Yeah forgot to mention that #define is an idiom of Task classes, just as much as #initialize initializes ivars.

@JonRowe
Copy link
Member

JonRowe commented Apr 18, 2014

I think it's ok as is commit message wise.

JonRowe added a commit that referenced this pull request Apr 18, 2014
@JonRowe JonRowe merged commit a1518a3 into rspec:master Apr 18, 2014
@JonRowe
Copy link
Member

JonRowe commented Apr 18, 2014

Thanks @postmodern :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants