Merge pull request #935 from rspec/fix_coveralls

Fix coveralls and a brittle test

Author: JonRowe

features/support/env.rb

@@ -12,7 +12,3 @@
   end
 end if RUBY_PLATFORM == 'java'
 
-require 'coveralls'
-Coveralls.wear! do
-  add_filter '/bundle/'
-end

script/test_all

@@ -21,7 +21,7 @@ echo "--------------------------------------------------------------------"
 echo
 
 for file in `find spec -iname '*_spec.rb'`; do
-  bin/rspec $file -b --format progress
+  NO_COVERALLS=1 bin/rspec $file -b --format progress
 done
 
 # Prepare RUBYOPT for scenarios that are shelling out to ruby,

spec/rspec/core/configuration_spec.rb

@@ -1098,22 +1098,24 @@ def metadata_hash(*args)
         debugger.should_receive(:start)
         config.debug = true
       end
-
-      it 'sets the reader to true' do
-        config.debug = true
-        expect(config.debug?).to eq true
-      end
     end
 
     describe "#debug=false" do
       it "does not require 'ruby-debug'" do
         config.should_not_receive(:require).with('ruby-debug')
         config.debug = false
       end
+    end
 
-      it 'sets the reader to false' do
-        config.debug = false
-        expect(config.debug?).to eq false
+    describe "#debug?" do
+      it 'returns true if the debugger has been loaded' do
+        stub_const("Debugger", Object.new)
+        expect(config.debug?).to be_true
+      end
+
+      it 'returns false if the debugger has not been loaded' do
+        hide_const("Debugger")
+        expect(config.debug?).to be_false
       end
     end
 

spec/spec_helper.rb

@@ -1,9 +1,13 @@
 require 'rubygems'
 
-require 'simplecov' if RUBY_VERSION.to_f > 1.8
-require 'coveralls'
-Coveralls.wear! do
-  add_filter '/bundle/'
+unless ENV['NO_COVERALLS']
+  require 'simplecov' if RUBY_VERSION.to_f > 1.8
+  require 'coveralls'
+  Coveralls.wear! do
+    add_filter '/bundle/'
+    add_filter '/spec/'
+    add_filter '/tmp/'
+  end
 end
 
 begin