-
-
Notifications
You must be signed in to change notification settings - Fork 753
Conversation
`#debug?` depends on whether or not the debugger is loaded. The tests for it were brittle and could start to fail if you were running the specs with the debugger loaded.
On the coveralls UI I'm seeing the same file listed many times. I think it's because we run all the specs together and then run each individually and the multiple test runs confuses it.
That last commit improved the coveralls percent but the results are still a bit odd. In our cukes, the rspec code is only run in a separate process started by aruba using the rspec command. I don't think that our cukes provide useful info about the coverage percent due to the separate processes.
We really only care about the coverage of our lib files.
On mocks I ended up using wear_merged! which is supposed to sorts the multiple files confusion, the downside is it requires an uber-rescue (which mock's needed anyway) to get it to run on 1.9.2. I've tried the same on exceptions to see if it improves the stats. I'd quite like to keep the cucumber as part of the coverage stats and if something is covered in them which isnt in specs I'd still like that chalked up as a win, but I'm open to removing it. |
It's not working on rspec-mocks. It's having the same problems: Under the hood, I believe it's using Simplecov's merging, which generally works w/o additional configuration when the multiple runs are different binaries (e.g. rspec and cucumber) but requires that you configure On top of that, there's no benefit to using coveralls/simplecov while running the individual spec files -- even if we got the merging to work, it's not going to provide us any more or less coverage.
The problem is that there's no way the basic cucumber setup you had can possibly work. Here's why:
|
Fair enough |
Fix coveralls and a brittle test
#debug?
depends on whether or not the debugger is loaded. The tests for it were brittle and could start to fail if you were running the specs with the debugger loaded.