This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Pass along opts from warn_deprecation #1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,16 +24,20 @@ | |||
| expect(RSpec.configuration.reporter).to receive(:deprecation).with(hash_including :message => "this is the message") | |||
| RSpec.warn_deprecation("this is the message") | |||
| end | |||
| it "passes along additional options" do | |||
There was a problem hiding this comment.
Mind adding a blank line above this? I personally dislike having examples crammed next to each other unless they are one-liners.
|
LGTM, merge when green. |
JonRowe
added a commit
that referenced
this pull request
Feb 22, 2014
Pass along opts from warn_deprecation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed as a counterpart to rspec/rspec-support#42 to eventually fix rspec/rspec-expectations#468