This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Dup formatters to prevent mutation #1486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -643,7 +643,7 @@ def default_formatter=(value) | |||
|
|
|||
| # @private | |||
| def formatters | |||
There was a problem hiding this comment.
I think we should make this method public and doc it. Without it being public there's no way to query RSpec to ask what formatters are being used. The doc can mention that a dup is returned.
| @@ -641,9 +641,16 @@ def default_formatter=(value) | |||
| formatter_loader.default_formatter = value | |||
| end | |||
|
|
|||
| # @private | |||
| # @api public | |||
There was a problem hiding this comment.
Is this necessary? I would expect YARD to treat it as public anyway...
(Don't hold off merging on this...I'm mostly just curious).
There was a problem hiding this comment.
I pruned it with a [skip ci] ;)
|
LGTM, merge when green. |
[skip ci]
[skip ci]
JonRowe
added a commit
that referenced
this pull request
Apr 16, 2014
Dup formatters to prevent mutation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counterpart to #1483 this prevents mutation of the formatter array.