Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Prevent doubles causing issues with inline subject. #1576

Merged
merged 2 commits into from
Jun 6, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions spec/rspec/core/memoized_helpers_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,18 @@ def subject_value_for(describe_arg, &block)
expect(example_yielded_to_subject).to eq example_yielded_to_example
end

context "doesn't issue a deprecation when used with doubles" do
subject do
Struct.new(:value) do
def working_with?(double)
double.value >= value
end
end.new 1
end

it { should be_working_with double(:value => 10) }
end

[false, nil].each do |falsy_value|
context "with a value of #{falsy_value.inspect}" do
it "is evaluated once per example" do
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ def without_env_vars(*vars)
end

# runtime options
c.raise_errors_for_deprecations!
c.color = true
c.include EnvHelpers
c.filter_run_excluding :ruby => lambda {|version|
Expand Down