This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Allowed stdlibs #1880
Merged
Allowed stdlibs #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /set\.rb/, # used in a few places but being removed in #1870. | ||
| /rbconfig\.rb/, # loaded by rspec-support for OS detection. | ||
| /shellwords\.rb/, # used by ConfigurationOptions and RakeTask. | ||
| /stringio/, # Used by BaseFormatter. |
There was a problem hiding this comment.
You know we could probably create something to replace this too...
There was a problem hiding this comment.
Yep, I was thinking the same, but figure we can circle back to it. I'd rather get this merged and figure that out later.
myronmarston
force-pushed
the
allowed-stdlibs
branch
2 times, most recently
from
78b6324 to
076da62
Compare
myronmarston
force-pushed
the
allowed-stdlibs
branch
from
076da62 to
08c4c7b
Compare
|
This is ready for review. /cc @JonRowe |
|
LGTM |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Allowed stdlibs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSpec-core's changes for rspec/rspec-support#179.
/cc @JonRowe