You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 30, 2024. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My main goal here was to add a section on scope. After reading http://therealadam.com/2015/03/01/its-not-your-fault-if-your-tools-confuse-you/ I realized we don't document scope very well. While reading through what we had in the README I noticed a number of things that could be improved so I went ahead and addressed those.
While it’s not normally needed (it has no code!),
some RSpec extensions depend directly on `rspec` and
in such situations you’ll need it to have the newer
version as well.
It’s important that you see the expectation fail
(it’s how you “test the test”, so to speak, and
you can confirm it gives you a good failure message),
so let’s not skip that step.
The prose on scoping is great. The scoping example code was initially surprising to me due to calling a method on super, which is not a thing I usually see or expect to see. The example transliterating the DSL to a hand-coded Ruby class is great too.
The prose on scoping is great. The scoping example code was initially surprising to me due to calling a method on super, which is not a thing I usually see or expect to see. The example transliterating the DSL to a hand-coded Ruby class is great too.
Thanks. I adapted the example from a prior response I had sent someone who had specifically asked if you can use super so it was a very arbitrary example that was attempting to demonstrate that...but it's totally unneeded here. I pushed an update...do you like that better?
The prose on scoping is great. The scoping example code was initially surprising to me due to calling a method on super, which is not a thing I usually see or expect to see. The example transliterating the DSL to a hand-coded Ruby class is great too.
Thanks. I adapted the example from a prior response I had sent someone who had specifically asked if you can use super so it was a very arbitrary example that was attempting to demonstrate that...but it's totally unneeded here. I pushed an update...do you like that better?
—
Reply to this email directly or view it on GitHub.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My main goal here was to add a section on scope. After reading http://therealadam.com/2015/03/01/its-not-your-fault-if-your-tools-confuse-you/ I realized we don't document scope very well. While reading through what we had in the README I noticed a number of things that could be improved so I went ahead and addressed those.