This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Add fallback formatter for #message #1980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
JonRowe
force-pushed
the
fallback_message_formatter
branch
from
93f1801 to
f10c115
Compare
|
Ping @myronmarston |
| # | ||
| # @param notification [MessageNotification] containing message | ||
| def message(notification) | ||
| output.puts notification.message |
There was a problem hiding this comment.
The build is failing because this line is not covered by a test. (script/rspec_with_simplecov will check coverage).
There was a problem hiding this comment.
Funny because we don't test this on any of the other formatters, oh well easily add a test
JonRowe
force-pushed
the
fallback_message_formatter
branch
from
f10c115 to
64658a3
Compare
JonRowe
force-pushed
the
fallback_message_formatter
branch
from
ff752da to
60b2dc7
Compare
|
Tweaked a bit |
|
LGTM |
JonRowe
added a commit
that referenced
this pull request
Jun 2, 2015
Add fallback formatter for #message
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
[skip ci]
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Add fallback formatter for #message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
MessageFormatteras a fallback when no other formatter in use implements#messageFixes #1978