This repository was archived by the owner on Nov 30, 2024. It is now read-only.
stop 70 being displayed as 1 minute 1 second #1984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why ci is failing, the change is fairly minor and the tests for the change and associated functionality are all fine |
|
If you read the build failure, it's because you have trailing whitespace on lines 48 and 94 of the spec file. |
| @@ -70,8 +70,7 @@ def self.format_seconds(float, precision=nil) | |||
| # @param string [String] string with trailing zeros | |||
| # @return [String] string with trailing zeros removed | |||
| def self.strip_trailing_zeroes(string) | |||
| stripped = string.sub(/[^1-9]+$/, '') | |||
| stripped.empty? ? "0" : stripped | |||
| string.sub(/(?:(\..*[^0])0+|\.0+)$/, '\1') | |||
There was a problem hiding this comment.
Can you add a rubular explanation here saying what this is doing e.g. http://rubular.com/r/ujWack5Utu
There was a problem hiding this comment.
No problem, added link to Rubular, with few more specific examples. Basically looks for a decimal point followed by any number of non-zeros, then a zero (or more). Or just a decimal point and zeros. Then replaces this with the first match (i.e. the non-zeros)
added 2 commits
June 8, 2015 11:06
myronmarston
added a commit
that referenced
this pull request
Jun 8, 2015
stop 70 being displayed as 1 minute 1 second
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
stop 70 being displayed as 1 minute 1 second
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
[ci skip]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
70 seconds was having trailing 0's stripped so shown as 1 minute, 1 second. Changed the helper regex, based on this SO answer: http://stackoverflow.com/a/4913031/671422