This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Fix group profiling #1992
Merged
Fix group profiling #1992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn’t even exercising any of the profile formatter code!
This shared group was only included at one place in this file but it looks like there were two intended inclusions. This fixes that.
|
LGTM merge when green On Friday, 12 June 2015, Myron Marston [email protected] wrote:
|
Regressions fixed by this commit: - We only considered top-level groups before, but #1971 made it consider nested groups as well. However, the example count was only incremented on the top-level group, which meant the output said “Inf seconds” since `float / 0` returns `Infinity`. - We were wrongly listing the example group class name rather than the location. This is because we changed from locations to groups in the hash. Fixes #1989.
Profile example group ordering no longer relies on `example.clock`. It relies directly on `RSpec::Core::Time.now` so we have to update the spec to make it consistent.
myronmarston
force-pushed
the
fix-group-profiling
branch
from
c775019 to
473e3ed
Compare
Figured out the source of a flicking test and addressed that. Hopefully it'll go green now. Going to bed (it's around 1 am here). |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Fix group profiling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1989.
/cc @JonRowe
(I'm hoping to release 3.3 tomorrow if we can get this merged...)