This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Combine multiple --pattern arguments
#2002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -214,6 +214,10 @@ def generate_help_text | |||
| options = Parser.parse([option, 'spec/**/*.spec']) | |||
| expect(options[:pattern]).to eq('spec/**/*.spec') | |||
| end | |||
| it 'will combine multple patterns' do | |||
There was a problem hiding this comment.
A blank line between examples would be nice for consistent formatting :).
Also, the will seems superfluous...why not it 'combines multiple patterns'?
|
Have you tried this from the CLI to confirm it works correctly? My knowledge of glob patterns is a little week so it LGTM to be but I'd have to test it manually to confirm it works properly. |
JonRowe
force-pushed
the
combine_multiple_patterns
branch
from
20f52ae to
5cf8e4f
Compare
JonRowe
force-pushed
the
combine_multiple_patterns
branch
from
5cf8e4f to
42f8ee9
Compare
|
Yep I checked :) |
|
LGTM then :). |
|
I had to disable cyclomatic complexity for the option parser, I don't think it's worth refactoring as isn't that complex, it's just the option parser DSL |
JonRowe
added a commit
that referenced
this pull request
Jun 18, 2015
Combine multiple `--pattern` arguments
This was referenced Jul 25, 2016
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Combine multiple `--pattern` arguments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2000