This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Lock example_status_persistence_file to prevent race conditions #2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empact
force-pushed
the
lock-example-status
branch
from
fe3499f to
0344881
Compare
|
This looks reasonable. Can you add a spec for this? |
|
It also looks like some specs are failing on 1.8.7 -- let us know if you want help with that. |
Empact
force-pushed
the
lock-example-status
branch
5 times, most recently
from
4498948 to
ad02a39
Compare
|
@myronmarston Ok tests passing now. I'm not super-familiar with the File / IO apis but this follows the example in the |
|
|
||
| # dumped status is called after the file is locked but before | ||
| # the output is written | ||
| allow(persister_1).to receive(:dumped_statuses) do |
There was a problem hiding this comment.
This can use receive(:dumped_statuses).and_wrap_original rather than capturing the method above.
There was a problem hiding this comment.
Nice - I was looking for that feature. Just a sec.
Empact
force-pushed
the
lock-example-status
branch
from
ad02a39 to
7db676c
Compare
This introduces file locking to ExampleStatusPersister#persist to avoid a race condition where parallel or unrelated spec runs race to update the same file: - read 1 - read 2 - write 1 - write 2 - write 1 is lost Because we need to read and write the file under the same lock, I inline #write into #persist so that dumped_statuses is called after the file is opened/locked.
Empact
force-pushed
the
lock-example-status
branch
from
7db676c to
7f8746f
Compare
myronmarston
added a commit
that referenced
this pull request
Jul 16, 2015
Lock example_status_persistence_file to prevent race conditions
|
Thanks, @Empact! |
myronmarston
added a commit
that referenced
this pull request
Jul 16, 2015
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Lock example_status_persistence_file to prevent race conditions
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
[skip ci]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces file locking to ExampleStatusPersister#persist to
avoid a race condition where parallel or unrelated spec runs race to
update the same file:
Because we need to read and write the file under the same lock,
I inline #write into #persist so that dumped_statuses is called
after the file is opened/locked.