Issue 2020 remove ansicon warning #2038
Conversation
| [MinGW](http://www.mingw.org/) (Minimalist GNU for Windows) | ||
|
|
||
| More information can be found by searching for information about those solutions. | ||
|
|
There was a problem hiding this comment.
👍 This is well written. Thanks for writing this up!
There was a problem hiding this comment.
Although, I'm realizing that a file named read_options_from_file.feature isn't a place users are likely to look for this info. WDYT about creating a features/configuration/color.feature file with color config info including this? If you go that route, would be nice to add the file to features/.nav so we can put it in the ordering we want.
There was a problem hiding this comment.
That makes good sense to me. That will be much more obvious on Relish and anywhere else. I'll make an entry in .nav. I'll put it after - read_options_from_file.feature because that references color and also because if people are having trouble with color, they'll see it quickly. But of course I'm happy to put it where-ever you think it should go in .nav.
|
made the changes. If they're ok, let me know if you want me to squash the commits. |
| @@ -0,0 +1,22 @@ | |||
| Feature: Windows may require additional solutions to display color | |||
|
|
|||
| The output uses ANSI escapte codes to show text in color. Windows | |||
There was a problem hiding this comment.
Also, do you think it's worth turning "ANSI escape codes" into a link to https://en.wikipedia.org/wiki/ANSI_escape_code ?
|
Yes, please squash the commits. Looks like the |
…s for Windows in colors.feature issue rspec#2020 don't need to test if ANSICON installed on windows (that's up to the user; ok if it isn't) document Windows utils available for showing color (ex: ANSICON and other solutions) moved 'Windows may need solutions to show ANSI codes' into its own feature file. Massaged text to it can stand alone. added new 'color.feature' file into .nav file after 'read_options_from_file.feature' (in configuration section) replaced color= method with attr_writer :color; fixed typo in color.feature. Added link to wikipedia definition for ANSI escape code in color.feature
weedySeaDragon
force-pushed
the
issue-2020--remove-ANSICON-warning
branch
from
3d0019b to
c72d232
Compare
|
I added commits squashed |
| def color | ||
| value_for(:color) { @color } | ||
| end | ||
| attr_writer :color |
There was a problem hiding this comment.
This is a replacement for the def color= method, not the def color method.
There was a problem hiding this comment.
Oh how embarrassing. (:head_smack:) Fixed.
…replaces the correct method
…ON-warning Issue 2020 remove ansicon warning
|
Thanks, @weedySeaDragon! |
…ANSICON-warning Issue 2020 remove ansicon warning
I just removed the code that tested for and warned about ANSICON.
I put documentation (a note about using ANSICON or other utilities) into
features/configuration/read_options_from_file.feature. I'm not sure if that's the right or best place for it. It seemed to be the most appropriate place.