This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Use our optimized require over a bare require. #2082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides being faster (at least for environments with lots of directories on the load path), this avoids potentially loading the file twice, since rspec-mocks loads it in this fashion rather than with a bare require. Fixes rspec/rspec-support#244.
| @@ -1,4 +1,4 @@ | |||
| require 'rspec/support/reentrant_mutex' | |||
| RSpec::Support.require_rspec_support 'reentrant_mutex' | |||
There was a problem hiding this comment.
Ah that's how it's happening, it's probably using the require_relative in the optimised one and that counts as a different require to the bare one.
JonRowe
added a commit
that referenced
this pull request
Oct 8, 2015
Use our optimized require over a bare require.
|
LGTM |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Use our optimized require over a bare require.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides being faster (at least for environments with lots
of directories on the load path), this avoids potentially
loading the file twice, since rspec-mocks loads it in this
fashion rather than with a bare require.
Fixes rspec/rspec-support#244.