This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Fix --tag documentation to avoid confusing "filter" references. #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in rspec#2017, the sentence fragment "then foo will be filtered" usually means that "foo" will be filtered out. The tag feature actually works the opposite way; "--tag foo" will only run examples with `foo: true`.
|
I think this is an improvement, thanks! |
JonRowe
added a commit
that referenced
this pull request
Oct 14, 2015
Fix --tag documentation to avoid confusing "filter" references.
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Fix --tag documentation to avoid confusing "filter" references.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #2017, the sentence fragment "then foo will be filtered" usually means that "foo" will be filtered out. The tag feature actually works the opposite way; "--tag foo" will only run examples with
foo: true.I've tried to tidy up this documentation to make this clearer, as well as moving the paragraph about internal details lower down so exclusions are discussed before we use them in an example.