This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Add duplicate_with for RSpec Example #2098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love how simple this is! |
JonRowe
added a commit
that referenced
this pull request
Oct 23, 2015
Add duplicate_with for RSpec Example
|
Contributing to rspec-core has been a great experience. Thanks for the timely feedback and code reviews. |
| new_metadata.delete reserved_key | ||
| end | ||
|
|
||
| Example.new(example_group.clone, description.clone, |
There was a problem hiding this comment.
The example group should not be cloned. The example should belong to the same example group class, not a copy of it. The clone is likely to cause some bugs.
There was a problem hiding this comment.
Nice catch. I'll submit a fix & update the spec to check this bug.
myrridin
pushed a commit
to myrridin/rspec-core
that referenced
this pull request
Dec 11, 2015
[skip ci]
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
…with Add duplicate_with for RSpec Example
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
[skip ci]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last of the new APIs as discussed in #2094