This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Handle syntax error in Ripper #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let(:line_number) do | ||
| 1 | ||
| end |
There was a problem hiding this comment.
Not a merge blocker, but I think I'd prefer the let declarations were on one line:
let(:file_path) { "invalid_source.rb" }
let(:line_number) { 1 }Why take up 7 lines when it can be 2?
There was a problem hiding this comment.
Recently I tend to use consistent block style in all contexts, though I won't insist.
yujinakayama
force-pushed
the
handle-syntax-error-in-ripper
branch
from
9aab631 to
d439a70
Compare
|
LGTM. Merge when green! |
yujinakayama
force-pushed
the
handle-syntax-error-in-ripper
branch
from
d439a70 to
3ee6c88
Compare
Ripper might fail to parse a Ruby source even if the current runtime parsed it properly, because some versions of JRuby have different implementation of runtime parser and Ripper parser. jruby/jruby#2427 So we handle the syntax error in Ripper and fall back to the simple single line extraction in that case.
yujinakayama
force-pushed
the
handle-syntax-error-in-ripper
branch
from
3ee6c88 to
f00ec60
Compare
yujinakayama
added a commit
that referenced
this pull request
Oct 31, 2015
Handle syntax error in Ripper
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Handle syntax error in Ripper
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ripper might fail to parse a Ruby source even if the current runtime parsed it properly, because some versions of JRuby have different implementation of runtime parser and Ripper parser.
jruby/jruby#2427
So we handle the syntax error in Ripper and fall back to the simple single line extraction in that case.