This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Followups from #2065. #2105
Merged
Followups from #2065. #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Better warning when an invalid value is passed for `--fail-fast` (including silencing call site since it will not be in user code). - No need to stub `reporter.failures_required`. - No need for the `failures_required` method at all. - Use `fail_fast_limit_met?` in more situations. - Remove unneeded `ExampleGroup.fail_fast?` method.
|
Thank you, great refactoring! |
|
Anyone want to review this? /cc @rspec/rspec |
|
LGTM 👍 |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Followups from rspec#2065.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
--fail-fast(including silencing call sitesince it will not be in user code).
reporter.failures_required.failures_requiredmethod at all.fail_fast_limit_met?in more situations.ExampleGroup.fail_fast?method.