This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Make wording more accurate. #2115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing wording was confusing for this situation: * You have two specs, a and b. * Spec a always fails. * Spec b fails only if a runs first. In such a situation, your failures are order dependent, but our bisector printed "failure is not order dependent", which was quite confusing. The new wording, "failures(s) do not require any non-failures to run first" is more accurate.
|
👍 |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Make wording more accurate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing wording was confusing for this situation:
In such a situation, your failures are order dependent,
but our bisector printed "failure is not order dependent",
which was quite confusing. The new wording,
"failures(s) do not require any non-failures to run first"
is more accurate.