This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Prevent bad version of nokogiri and fix build #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
added a commit
that referenced
this pull request
Dec 24, 2015
Prevent bad version of nokogiri and fix build
This was referenced Dec 24, 2015
|
Merged despite error because it needs all three simultaneously. See rspec/rspec-rails#1510 rspec/rspec-support#258 and #2140 |
| @@ -42,7 +42,7 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency "minitest", "~> 5.3" | |||
| s.add_development_dependency "aruba", "~> 0.6.2" # 0.7 is broken on ruby 1.8.7 | |||
|
|
|||
| s.add_development_dependency "nokogiri", (RUBY_VERSION < '1.9.3' ? "1.5.2" : ["~> 1.5", "!= 1.6.6.3", "!= 1.6.6.4"]) | |||
| s.add_development_dependency "nokogiri", (RUBY_VERSION < '1.9.3' ? "1.5.2" : ["~> 1.5", "!= 1.6.6.3", "!= 1.6.6.4", "!= 1.6.7.1"]) | |||
There was a problem hiding this comment.
Wow. Crazy the hoops we have to jump through here :(.
Makes me wonder if there's something different we can use...
There was a problem hiding this comment.
It's because we disable ruby gems apparently
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Prevent bad version of nokogiri and fix build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.