This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Remove nokogiri development dependency #2149
Merged
+102
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujinakayama
force-pushed
the
remove-nokogiri
branch
from
7009c33 to
664c719
Compare
| @@ -41,6 +25,12 @@ module Formatters | |||
| allow(RSpec.configuration).to receive(:load_spec_files) do | |||
| RSpec.configuration.files_to_run.map {|f| load File.expand_path(f) } | |||
| end | |||
|
|
|||
| # This is to minimize churn on backtrace lines | |||
| allow_any_instance_of(Notifications::FailedExampleNotification). | |||
There was a problem hiding this comment.
Given we recommend against allow_any_instance_of, it's worth considering alternatives here. Can the interface be improved to make this simpler? Or can we use stub_const to replace a constant with an alternate implementation for this test?
There was a problem hiding this comment.
We could filter the backtrace using Configuration#backtrace_exclusion_patterns / #backtrace_inclusion_patterns 😁
|
👍 Nice to see how easy it was to remove! It's also great to see that this fixes an appveyor problem. |
yujinakayama
force-pushed
the
remove-nokogiri
branch
from
664c719 to
337ad93
Compare
yujinakayama
force-pushed
the
remove-nokogiri
branch
from
337ad93 to
2ec1ab5
Compare
yujinakayama
added a commit
that referenced
this pull request
Jan 2, 2016
Remove nokogiri development dependency
|
This is fantastic! Thanks, @yujinakayama ! |
|
@yujinakayama nice find! ❤️ ❤️ ❤️ |
yujinakayama
added a commit
that referenced
this pull request
Jan 7, 2016
Remove nokogiri development dependency Conflicts: rspec-core.gemspec
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Remove nokogiri development dependency
yujinakayama
added a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…ogiri Remove nokogiri development dependency Conflicts: rspec-core.gemspec --- This commit was imported from rspec/rspec-core@1a7c8db.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: rspec/rspec-expectations#882
It's only used to filter backtrace in HtmlFormatter spec but it can be replaced and simplified with the backtrace filtering API.