This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Fix drb weirdness #2165
Merged
Fix drb weirdness #2165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the comment explains, I have had to configure my network adapter in a non-standard way, and it causes `IPSocket.getaddress(Socket.gethostname)` to raise an error for me. A couple of the DRb specs were failing as a result. The use of `return` from `ensure` caused the error to be ignored (the fact that `local_drb` was not set caused it to return false). This was confusing, and using `return` from `ensure` is a horrible practice. I have refactored to avoid the issue, rescuing errors explicitly.
myronmarston
force-pushed
the
fix-drb-weirdness
branch
from
34ed051 to
824fdd9
Compare
|
LGTM |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Fix drb weirdness
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DRb specs that are failing for me locally.
As the comment explains, I have had to configure my network
adapter in a non-standard way, and it causes
IPSocket.getaddress(Socket.gethostname)to raise an errorfor me.
A couple of the DRb specs were failing as a result. The use of
returnfromensurecaused the error to be ignored (the factthat
local_drbwas not set caused it to return false). This wasconfusing, and using
returnfromensureis a horrible practice. I have refactored to avoid the issue, rescuingerrors explicitly.