This repository was archived by the owner on Nov 30, 2024. It is now read-only.
When filtering, do not consider declaration lines from other files. #2170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
issue-2136
branch
from
fecc970 to
d92eb0c
Compare
myronmarston
force-pushed
the
issue-2136
branch
2 times, most recently
from
41aced6 to
7da9203
Compare
Before this, our logic for line number filtering asked `RSpec.world` for the preceding declaration line of a particular line number, *without* passing it a file name, which meant that it looked at the declaration line numbers from _all_ files. This was prone to producing weird filtering behavior. Fixes #2136.
myronmarston
force-pushed
the
issue-2136
branch
from
7da9203 to
358733a
Compare
|
This is green now. Can someone from @rspec/rspec review? |
|
Looks sane to me |
JonRowe
added a commit
that referenced
this pull request
Feb 9, 2016
When filtering, do not consider declaration lines from other files.
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
When filtering, do not consider declaration lines from other files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, our logic for line number filtering asked
RSpec.worldfor the preceding declaration line of a particular line number,
without passing it a file name, which meant that it looked at
the declaration line numbers from all files. This was prone to
producing weird filtering behavior.
Fixes #2136.