This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Deal with circular relationship between world and config #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some config methods use `RSpec.world` and have problems if `RSpec.world` has not been defined yet. So it's best to wait to configure anything until `RSpec` is defined.
myronmarston
force-pushed
the
world-configuration-circular
branch
from
fcf9a77 to
d53df3a
Compare
myronmarston
changed the title
`RSpec::World#initialize` references `RSpec.configuration` and `RSpec::Configuration` references `RSpec.world` in a few places. This circular dependency is not ideal and has triggered infinite recursion during some recent changes I've tried to make. It would be nice to get rid of it entirely, but for now, this is the simplest change I can make it solve my immediate problems.
myronmarston
force-pushed
the
world-configuration-circular
branch
from
d53df3a to
fc0e6b5
Compare
| @@ -178,4 +177,7 @@ def self.const_missing(name) | |||
| require MODULES_TO_AUTOLOAD.fetch(name) { return super } | |||
| ::RSpec.const_get(name) | |||
| end | |||
|
|
|||
| Core::DSL.expose_globally! | |||
| Core::SharedExampleGroup::TopLevelDSL.expose_globally! | |||
There was a problem hiding this comment.
Whilst I get that this is to prevent configuration being loaded prematurely, feels a bit like duplication :/
There was a problem hiding this comment.
The loading and using of configuration in this file was causing problems for me and the config.expose_dsl_globally = true doesn't set any state in config so this seemed like the simplest solution. Do you have a suggested alternative that doesn't involve reverting to config.expose_dsl_globally = true?
There was a problem hiding this comment.
No, and I think this is better than adding a new method.
JonRowe
added a commit
that referenced
this pull request
Mar 3, 2016
Deal with circular relationship between world and config
|
LGTM |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Deal with circular relationship between world and config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSpec::World#initializereferencesRSpec.configurationand
RSpec::ConfigurationreferencesRSpec.worldin a fewplaces. This circular dependency is not ideal and has triggered
infinite recursion during some recent changes I've tried to make.
It would be nice to get rid of it entirely, but for now, this is
the simplest change I can make it solve my immediate problems.